TZAbstractConnection.ConnectionLost issue

[stoffman]

In TZAbstractConnection.ConnectionLost the event is never considered to be raised i.e. EventErrorRaised is always False. It should be set under an else statement

https://github.com/frones/ZeosLib/blob/ ... .pas#L1032

p.s.
I think reordering the code would make it much more easier to reason about:

Code: Select all

EventErrorRaised = False
if Assigned(FOnLost) then begin
  EventErrorRaised := true;
  FOnLost(Self);
end;

[aehimself]

It won't be false, if a custom exception is raised and handled WITHIN the event handler itself... like

Code: Select all

Procedure TConnection.OnLost(Sender: TObject);
Begin
  Raise Exception.Create('Connection to the database server was lost, please call 911');
End;

If no custom exception was raised we create and raise one at line 1048.

[stoffman]

Thanks, I now understand the interface. connection lost will always raise an exception.