Page 1 of 1

unit ZAbstractRODataset, possible bug or wrong indentation

Posted: 13.09.2017, 12:25
by Fr0sT
unit ZAbstractRODataset, method TZAbstractRODataset.InternalOpen contains this fragment:

Code: Select all

    { Creates an SQL statement and resultsets }
    if not FUseCurrentStatment then
      if FSQL.StatementCount> 0 then
        ResultSet := CreateResultSet(FSQL.Statements[0].SQL, -1)
      else
        ResultSet := CreateResultSet('', -1);
      if not Assigned(ResultSet) then
      begin
        if not (doSmartOpen in FOptions) then
          raise Exception.Create(SCanNotOpenResultSet)
        else
          Exit;
      end;
The "if not Assigned(ResultSet)" block is indented so it possibly was meant to be inside "if not FUseCurrentStatment" block. Or it has excess indentation.