Page 1 of 1

[patch_done] Small changes for Protocol "mssql"

Posted: 07.06.2013, 20:42
by mmvisual
I have use Zeos 7.0.3 and include some changes for using mssql driver.
The problems where I have fixed:
- Date format for Insert/Update
- reserved Keywords
- Accept the field type "VARBINARY(MAX)" (No 37), it is a BLOB (I have change it for Sybase, too but not testet.

In attachment my corrected files, the code have I modified from SVN 2286 / 7.1.0. The new file have the ending ".pas", the original file ".pas.bak" then you can see my small modifications.

Please include this bugfix into your original source, just, I must include it manually in every update from your SVN.

Best Regards Markus

Posted: 08.06.2013, 20:27
by EgonHugeist
mmvisual,

Markus, i've commited the ZDbcMetaData.pas and ZDbDbLibMetadata.pas changes.
Patch done R2288 \testing7.1 (SVN).

Thank you. (Btw. availibe on Skype again)

The ZDbcDblibUtils.pas pach kills my tests. (It works perfektly on my environment-settings) So we've to look how we can get an common behavior.

Proposal:
instead of using the 'hard coded' Zeos-FormatSettings we should work out a way to:
- determine the current format-settings after login
or
- Set the Zeos FormatSettings to the current connection.
or
- a TZConnection Property for reading/writing Date/Time/DateTime formats.

Any ideas? Theire was another user who was running into the same issue with PostgreSQL. (Last 7.0 Beta thread).

Posted: 08.06.2013, 20:41
by mmvisual
Hallo Michael,
I have skype active.

I have think so, too. The hard coded DateTime format is not good. But I do not know the right way. I think a parameter in TZConnection is the best way. Then all users can see it in the Objectinspektor and change the settings how they want. (the same like "LibraryLocation")

Best Regards Markus

PS: Ich habe seit ein paar Tagen einen Mac geschenkt bekommen und versuche damit mein EleLa Projekt zum laufen zu bekommen. Klappt leider nicht so recht, bin mir aber noch nicht so sicher woran das liegt, an Lazarus oder an Zeos, da es mir das Formular (.lfm) zerschiesst.

Posted: 09.06.2013, 14:07
by EgonHugeist
mmvisual,

Patch done R2291 /testing7.1 (SVN). Case closed?