Bookmarks not working in XE3

[BitBumper]

Hi,
had the problem, that Bookmarks did not work in
Delphi XE3 with Zeos current trunk and current testing branch.

Figured out, that in Delphi Unit Data.Db the method
TDataSet.GetBookmarkData
was defined like this:

procedure GetBookmarkData(Buffer: TRecordBuffer; Data: TBookmark); overload; virtual;

While in TZAbstractRODataset the method was declared as

procedure GetBookmarkData(Buffer: TRecordBuffer; Data: Pointer); override;

Due to the different declaration the override was never called.
I changed this into

procedure GetBookmarkData(Buffer: TRecordBuffer; Data: TBookmark); override;

and Bookmarks work fine now.

Don't know much of the background of this - but may someone want to check this for the next release.

Greetings,

BitBumper

[EgonHugeist]

BitBumper,

danke dir. Patch applied Rev.1939 \testing (SVN)

IMHO SetBookmarkData was also involved, right?