[patch_done] Patch for ZDbcMetadata

[Ostfriese]

The function GetBestRowIdentifier has to variables (IndexName and ColumnNames) which are declared but never used.
So I commented them out to stop bloating the compiler log

Code: Select all

function TZAbstractDatabaseMetadata.GetBestRowIdentifier(const Catalog: string;
  const Schema: string; const Table: string; Scope: Integer; Nullable: Boolean): IZResultSet;
var
  Key: string;
  //HA 090515 remove unused variables ..
  //IndexName: string;
  //ColumnNames: TStrings;
  //..
begin
  Key := GetBestRowIdentifierCacheKey(Catalog, Schema, Table, Scope,
    Nullable);

  Result := GetResultSetFromCache(Key);
  if Result = nil then
  begin
    Result := UncachedGetBestRowIdentifier(Catalog, Schema, Table, Scope, Nullable);
    AddResultSetToCache(Key, Result);
  end;
end;

and the same thing for UncachedGetCrossReference which has one unused variable declared

Code: Select all

function TZAbstractDatabaseMetadata.UncachedGetCrossReference(const PrimaryCatalog: string;
  const PrimarySchema: string; const PrimaryTable: string; const ForeignCatalog: string;
  const ForeignSchema: string; const ForeignTable: string): IZResultSet;
//HA 090515 remove unused variables ..
//var
  //Key: string;
//..
begin
    Result := ConstructVirtualResultSet(CrossRefColumnsDynArray);
end;

[mdaems]

This one is already in 6.6-patches. See http://fisheye2.atlassian.com/changelog/zeos?cs=512

Mark