unit ZAbstractRODataset, possible bug or wrong indentation

The forum for ZeosLib 7.2 Report problems. Ask for help, post proposals for the new version and Zeoslib 7.2 features here. This is a forum that will be edited once the 7.2.x version goes into RC/stable!!

My personal intention for 7.2 is to speed up the internals as optimal a possible for all IDE's. Hope you can help?! Have fun with testing 7.2
Post Reply
Fr0sT
Zeos Dev Team
Zeos Dev Team
Posts: 280
Joined: 08.05.2014, 12:08

unit ZAbstractRODataset, possible bug or wrong indentation

Post by Fr0sT »

unit ZAbstractRODataset, method TZAbstractRODataset.InternalOpen contains this fragment:

Code: Select all

    { Creates an SQL statement and resultsets }
    if not FUseCurrentStatment then
      if FSQL.StatementCount> 0 then
        ResultSet := CreateResultSet(FSQL.Statements[0].SQL, -1)
      else
        ResultSet := CreateResultSet('', -1);
      if not Assigned(ResultSet) then
      begin
        if not (doSmartOpen in FOptions) then
          raise Exception.Create(SCanNotOpenResultSet)
        else
          Exit;
      end;
The "if not Assigned(ResultSet)" block is indented so it possibly was meant to be inside "if not FUseCurrentStatment" block. Or it has excess indentation.
Post Reply