Locate problem

[Christian]

I have big trouble with zeos Locate.
Locate dont match records with both an clear Field. For my opinion this is wrong

Example:

I Search for

ID;VERSION;LANGUAGE
01,NULL, EN


In my Dataset exists an exact Match for this

01,NULL, EN

Zeos says thers no match couse VERSION is NULL....

In ZDataSetutils in CompareFieldsFromResultSet

is one Line at Line 10801 : Result := Result and not ResultSet.WasNull;
Thats the problem. Ive commented it out and everything is fine.
Why is this so ?
Is it needed ?

best Regards
Christian

[Cocky]

I would be also interested in an answer.

best regards

Cocky

[mdaems]

Can you make a test project (a very simple one) including a table creation script and file it in the bug tracker? (http://zeosbugs.firmos.at/)
Like a TZConnection, a TZQuery and a button which opens the query and then does the locate returning the wrong result? That's something I can debug. Don't forget to mention compiler and database you are using.

Mark

[seawolf]

Try this test (package ZTestComponentAll, unit ZTestDatasetGeneric)

procedure TZGenericTestDbcResultSet.TestQueryLocate;
var
Query: TZQuery;
ResData : boolean;
begin
Query := TZQuery.Create(nil);
try
Query.Connection := Connection;
Query.SQL.Add('select * from cargo');
Query.ExecSQL;
Query.Open;
Check(Query.RecordCount > 0, 'Query return no records');
ResData := Query.Locate('C_DEP_ID;C_WIDTH;C_SEAL',VarArrayOf(['1','10','2']),[loCaseInsensitive]);
CheckEquals(ResData,true);
ResData := Query.Locate('C_DEP_ID,C_WIDTH,C_SEAL',VarArrayOf(['2',varNull,'1']),[loCaseInsensitive]);
CheckEquals(ResData,true);
finally
Query.Free;
end;
end;

First and second check are ok, but 3rd always return false

The problem is located on that line

Query.Locate('C_DEP_ID,C_WIDTH,C_SEAL',VarArrayOf(['2',varNull,'1']),[loCaseInsensitive]);
CheckEquals(ResData,true);

Could be?

Query.Locate('C_DEP_ID,C_WIDTH,C_SEAL',VarArrayOf(['2',varEmpty,'1']),[loCaseInsensitive]);
CheckEquals(ResData,true);

Could be?

Query.Locate('C_DEP_ID,C_WIDTH,C_SEAL',VarArrayOf(['2','','1']),[loCaseInsensitive]);
CheckEquals(ResData,true);

Could be?

Query.Locate('C_DEP_ID,C_WIDTH,C_SEAL',VarArrayOf(['2','NULL','1']),[loCaseInsensitive]);
CheckEquals(ResData,true);

[mdaems]

seawolf,
I'm afraid your test is wrong.

Code: Select all

VarArrayOf(['2',varNull,'1'])

is equal to

Code: Select all

VarArrayOf(['2',1,'1'])

Of course, this doesn't return a result.
Use

Code: Select all

VarArrayOf(['2',Null,'1'])

Now the tests do work correctly. I'll add them to the test suite next time I commit.
A remark : you should use

Code: Select all

CheckEquals(true,ResData);

instead of

Code: Select all

CheckEquals(ResData,true);

The expected value comes first.

Cocky,
Christian,
Waiting for an exact sample of your problem.

Mark

[Christian]

With actual SVN it seems to work now. Have removed my patch from my local code repositore and first try seems to work.