[patch_done] Some more patches from mariuszekpl

[mariuszekpl]

New version

Now I can update dataset, i fix errors in ZSqLiteToken.pas

[mariuszekpl]

And i can open database (sqlite) with UNICODE name like this

ZConnection1.Database := 'c:\dane-ŁŁŁĘĘĘĘ-ЫФЫФДЛДЛДЛДкенке.db';
ZConnection1.Connected := true;

[mariuszekpl]

Delphi in a Unicode World:
http://dn.codegear.com/article/38437
http://dn.codegear.com/article/38498
http://dn.codegear.com/article/38693

http://dn.codegear.com/article/images/3 ... nicode.pdf

[mdaems]

Thanks,

I'll have a look at it later.
Splitted again. Please make sure you use the button 'New topic' when you want to add something new. Certainly when the [patch_applied] symbol is in the title of your post.

Found something myself :

Code: Select all

    ErrorCode := FPlainDriver.Key(FHandle, PAnsiChar(Password), StrLen(PChar(Password)));

Some PChar remained in the code...

Mark

[mdaems]

mariuszekpl,

Thanks for the reading. I'm half way through now... Unfortunately this reading doesn't talk about how to keep your code usable in D2009 AND older versions. And for libraries, I would think this is an important issue.
(And then we don't talk about compatible with FPC)

Now, on your fixes. You'll notice I skipped them when adding your other patches to SVN.

The reason for the first one : this is not only a SQLiteToken issue. I bet it's the same problem in all tokenizers. Let's not start changing bugs for one database only when exists for all databases. So, you can provide a patch for all databases, or it will do it myself for the other databases but that will take some more time.

For the second one I'm afraid some more explanation is used. This code had been added because of http://fisheye2.atlassian.com/changelog/zeos?cs=246, and now you remove it alltogether for all compilers.
Can you explain?

Thanks,

Mark

[mariuszekpl]

I to try write code compatible with all version delphi.
But i have only Delphi 2006 and can test code only with Delphi 2006.
I try install Lasarus in next week.

I can look after other databases

[mdaems]

The Tokenizer TStream.Read(), TStream.Seek() and TStream.Write() stuff should be allright now.

The Filename patch is still open for investigation. See http://zeos.firmos.at/viewtopic.php?t=2144.

Mark