GetSequence metadata for Oracle

[aehimself]

Hello,

Since I needed it and it was not yet implemented I added the sequence collection for Oracle.
Unfortunately I was unable to find how I can connect a sequence to a catalog and a schema (if it can be at all) so those fields are left empty.

Pull request is available on GitHub as usual.

Cheers!

[MJFShark]

I may be misunderstanding, but for Oracle catalog should be empty and schema should be the SEQUENCE_OWNER column of ALL_SEQUENCES.

Also in the pull request is the following incorrect?

Code: Select all

     if FConSettings.ClientCodePage.Encoding = ceUTF16 then begin
        Result.UpdatePAnsiChar(SequenceNameIndex, GetPAnsiChar(SEQ_NAME_INDEX, Len), Len);
      end else begin
        Result.UpdatePWideChar(SequenceNameIndex, GetPWideChar(SEQ_NAME_INDEX, Len), Len);
      end;

to my eye it looks like it should be:

Code: Select all

     if FConSettings.ClientCodePage.Encoding = ceUTF16 then begin
        Result.UpdatePWideChar(SequenceNameIndex, GetPWideChar(SEQ_NAME_INDEX, Len), Len);
      end else begin
        Result.UpdatePAnsiChar(SequenceNameIndex, GetPAnsiChar(SEQ_NAME_INDEX, Len), Len);
      end;

Good job on the new feature!

-Mark