Search found 263 matches

by Fr0sT
22.01.2018, 09:24
Forum: ZeosLib 7.2 Forum
Topic: Error in TDatasetUtils.DefineKeyFields
Replies: 4
Views: 779

Re: Error in TDatasetUtils.DefineKeyFields

Maybe it's more correct to add Connection parameter and use Connection.GetMetadata.GetIdentifierConvertor.Quote for this purpose? The routine is called from 2 places only and is not intended for public usage so the change should be painless.
by Fr0sT
22.01.2018, 08:22
Forum: ZeosLib 7.2 Forum
Topic: Release Preparation
Replies: 11
Views: 1494

Re: Release Preparation

I don't have pending significant changes to 7.2 too.
As for the docs: honestly I couldn't overcome the process. I even installed TeX editor/compiler but it still too damn messy so I just read comments in the code :).
by Fr0sT
22.01.2018, 08:02
Forum: Firebird
Topic: Support for CHAR(16) CHARACTER SET OCTETS
Replies: 22
Views: 5211

Re: Support for CHAR(16) CHARACTER SET OCTETS

Hello Jan,
if widening a metadata query scheme is OK then I agree that's the most correct option. I'll try to make this update this week.
by Fr0sT
17.01.2018, 08:35
Forum: ZeosLib 7.2 Forum
Topic: Problems in the field editor with fields of the same name in two different tables
Replies: 40
Views: 4848

Re: Problems in the field editor with fields of the same name in two different tables

So - what's the final decision?
As fas as I'm concerned, the problem completely lies in generic (for all drivers) methods. I found no FB-specific methods that could be modified to resolve the issue.
by Fr0sT
17.01.2018, 08:22
Forum: Firebird
Topic: Support for CHAR(16) CHARACTER SET OCTETS
Replies: 22
Views: 5211

Re: Support for CHAR(16) CHARACTER SET OCTETS

So - what's the decision? 1. Add some code around ConvertInterbase6ToSqlType - OK 2. Add GUID fields list property - OK 3. Add GUID domains list property - ? Requires adding domain column but the resulting RS' scheme is common for all drivers so this addition will touch some piece of generic code. A...
by Fr0sT
12.01.2018, 08:46
Forum: ZeosLib 7.2 Forum
Topic: Problems in the field editor with fields of the same name in two different tables
Replies: 40
Views: 4848

Re: Problems in the field editor with fields of the same name in two different tables

Hello Jan, This is what we propose for Firebird in Zeos 7.2. If I understood you correctly, the problem is, that a caller calls GetColumns with the tablename quoted -> "TableName" instead of TableName. So for Zeos 7.2 the Firebird driver should remove the quotes if they are supplied before...
by Fr0sT
12.01.2018, 08:34
Forum: Firebird
Topic: Support for CHAR(16) CHARACTER SET OCTETS
Replies: 22
Views: 5211

Re: Support for CHAR(16) CHARACTER SET OCTETS

Hello Jan,
this seems reasonable. ConvertInterbase6ToSqlType is called only 3 times so it's better to extend callers - ConvertInterbase6ToSqlType itself is too low-level to deal with configurations.
by Fr0sT
11.01.2018, 14:39
Forum: ZeosLib 7.2 Forum
Topic: Problems in the field editor with fields of the same name in two different tables
Replies: 40
Views: 4848

Re: Problems in the field editor with fields of the same name in two different tables

Hello Jan, we think that in Zeos 7.2 the Firebird driver should be made to accept quoted identifiers and remove the quotes if necessary The problem is that this stuff has no relations to FB: ZDbcResultSetMetadata.TZAbstractResultSetMetadata.LoadColumn ZDbcResultSetMetadata.TZAbstractResultSetMetadat...
by Fr0sT
11.01.2018, 13:52
Forum: Firebird
Topic: Support for CHAR(16) CHARACTER SET OCTETS
Replies: 22
Views: 5211

Re: Support for CHAR(16) CHARACTER SET OCTETS

Jan, But in any bigger application it would require the developer to do tedious work when he has to specify the fields again and again and again. This is an invitation for human error - either by forgetting to specify the GUID-Fields at all or by spelling errors. The property could be generated prog...
by Fr0sT
10.01.2018, 15:17
Forum: ZeosLib 7.2 Forum
Topic: Problems in the field editor with fields of the same name in two different tables
Replies: 40
Views: 4848

Re: Problems in the field editor with fields of the same name in two different tables

Hello Jan, no it's not the case. Everything is called correctly but then the field name to find ( '"SomeField"' ) is compared with string value from metadata query which not includes quotes ( 'SomeField' ) and of course comparison fails. In fact I did some tests and I suspect there's no su...
by Fr0sT
10.01.2018, 15:07
Forum: Firebird
Topic: Support for CHAR(16) CHARACTER SET OCTETS
Replies: 22
Views: 5211

Re: Support for CHAR(16) CHARACTER SET OCTETS

I dislike the pattern patch idea. DB scheme is very likely to be unchangeable (or requiring too much efforts especially considering that UID fields are commonly keys). Moreover, what if someone has a field named, say, user_GUIDe ? The same for domain approach. I'd vote for per-dataset option which i...
by Fr0sT
10.01.2018, 09:46
Forum: ZeosLib 7.2 Forum
Topic: Problems in the field editor with fields of the same name in two different tables
Replies: 40
Views: 4848

Re: Problems in the field editor with fields of the same name in two different tables

As far as I see the root of the issue are quoted field names (I told they're evil!). FB query for table metadata executed in TZInterbase6DatabaseMetadata.UncachedGetColumns returns these names unquoted so comparations with quoted name in TZAbstractResultSetMetadata.ReadColumnByName all fail (you can...
by Fr0sT
09.01.2018, 16:47
Forum: ZeosLib 7.2 Forum
Topic: Problems in the field editor with fields of the same name in two different tables
Replies: 40
Views: 4848

Re: Problems in the field editor with fields of the same name in two different tables

Are you telling that selecting fields with aliases produce the same result? Very hardly but who knows... If you provide minimal reproducible database sample or a whole project it will be easier to locate the issue.
by Fr0sT
09.01.2018, 13:15
Forum: Firebird
Topic: Firebird and TGuidField
Replies: 3
Views: 1966

Re: Firebird and TGuidField

There is related topic in FB subforum. I'd suggest to go there and discuss implementation details